Conversation
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| defaultSuggestion: { | ||
| control: { type: 'number' }, | ||
| }, | ||
| dropAlign: dropAlignArg, |
There was a problem hiding this comment.
wondering if we should leave the dropAlign off?
<TextInput
aria-label="search"
icon={<SearchIcon />}
placeholder="Search"
reverse
value={value}
onChange={event => setValue(event.target.value)}
type="search"
{...props}
/>
we usually dont use it in our code examples
There was a problem hiding this comment.
Removed dropAlign
| reverse: true, | ||
| suggestions: ['Suggestion 1', 'Suggestion 2', 'Suggestion 3'], | ||
| textAlign: undefined, | ||
| width: undefined, |
There was a problem hiding this comment.
should we do medium as default so its not as long width wide
There was a problem hiding this comment.
Tried setting width medium, but it puts the icon way outside the input container. Wondering if I should just remove the width prop, not sure we want people in hpe doing that
There was a problem hiding this comment.
Removed width for now
There was a problem hiding this comment.
oh weird yeah I didnt notice that
There was a problem hiding this comment.
Im good with leaving it out for now
| suggestions: { | ||
| control: { type: 'object' }, | ||
| }, | ||
| textAlign: { |
There was a problem hiding this comment.
This feels like it could become a commonArg - willing to approve and revise later if needed.
There was a problem hiding this comment.
Good call, changed this to be a commonArg
seanhillweb
left a comment
seanhillweb
left a comment
There was a problem hiding this comment.
Left a minor note regarding textAlign but otherwise this looks good to me.
3 participants
https://deploy-preview-5795--unrivaled-bublanina-3a9bae.netlify.app/?path=/story/components-textinput--search-example
What does this PR do?
Add search story
What are the relevant issues?
#5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?